-
Notifications
You must be signed in to change notification settings - Fork 736
Add ability to select a document's project context #7328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| "Open solution": "Open solution", | ||
| "Select context": "Select context", | ||
| "C# Project Context Status": "C# Project Context Status", | ||
| "Active File Context": "Active File Context", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering - could we merge this into the select button?
e.g.
ProjectA (net6.0) Change Active File Context
or maybe we could even put the document name in it?
ProjectA (net6.0) Change Program.cs Context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, although the select command is only visible when there are multiple project contexts. Would it be jarring for the text to move from the item details to the command and back again as you navigate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah hmm. I wonder if we should just always show the button even if there's only one. Not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should get it into preview in its current form and work out user experiences issues from there.
6ca46de to
44b576a
Compare
44b576a to
ee62554
Compare
ee62554 to
0865483
Compare
- Adds select project context commands - Adds the select command to the Project Context status item - Updates middleware to send selected context with server requests.
0865483 to
21ed6a9
Compare
| * Handle conflict markers (PR: [#12642](https://github.com/dotnet/razor/pull/12642)) | ||
| * Fix cross project span and edit mapping (PR: [#12614](https://github.com/dotnet/razor/pull/12614)) | ||
| * Update Roslyn to 5.4.0-2.26060.1 (PR: [#8877](https://github.com/dotnet/vscode-csharp/pull/8877)) | ||
| * Filter our html diagnostics when a tag helper attribute spans multiple lines (PR: [#12654](https://github.com/dotnet/razor/pull/12654)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed some trailing whitespace from Razor entries.
Adds the ability to select a document's project context. Uses the key added in dotnet/roslyn#81940 to ensure all documents that have the same set of contexts use the same active context.
Screen.Recording.2026-01-12.at.11.13.23.PM.mov
See all Roslyn changes...
View Complete Diff of Changes